Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb7a64de99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/app/src/app/api/security/vulnerability-reports/[id]/report/route.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2df06e6b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/app/src/app/api/security/vulnerability-reports/webhook/route.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e4c528f51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/app/src/app/api/security/vulnerability-reports/_api-proxy.ts
Outdated
Show resolved
Hide resolved
apps/api/src/security-vulnerability-reports/security-vulnerability-reports.service.ts
Outdated
Show resolved
Hide resolved
… Maced webhook reconciliation
apps/api/src/security-vulnerability-reports/security-vulnerability-reports.service.ts
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a1e273ab0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/app/src/app/api/security/vulnerability-reports/_api-proxy.ts
Outdated
Show resolved
Hide resolved
apps/api/src/security-penetration-tests/security-penetration-tests.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be16674dad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/api/src/security-vulnerability-reports/security-vulnerability-reports.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 789fb5eb34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7273e28c53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/api/src/security-penetration-tests/security-penetration-tests.service.ts
Show resolved
Hide resolved
apps/api/src/security-penetration-tests/security-penetration-tests.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77ab81e683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apps/api/src/security-penetration-tests/security-penetration-tests.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49f6031f4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/db/prisma/migrations/20260302113000_add_security_penetration_test_runs/migration.sql
Outdated
Show resolved
Hide resolved
apps/api/src/security-penetration-tests/security-penetration-tests.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b91d508b9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (response.status < 200 || response.status >= 300) { | ||
| throw new Error(response.error ?? `Request failed with status ${response.status}`); |
There was a problem hiding this comment.
Surface provider error details on create failures
This branch throws response.error, but the browser API client currently only populates that field from data.message (not data.error), while the new penetration-test backend paths commonly return errors as { "error": ... } (for example in security-penetration-tests.service.ts). In those cases users get a generic HTTP 4xx message instead of the real validation/provider error, which makes create-run failures hard to diagnose and breaks the UX expected by this flow.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 1.87.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
This PR ships the new Security → Penetration Tests capability end-to-end.
It introduces a complete one-time penetration test lifecycle:
Final architecture
User flow
POST /v1/security-penetration-tests.organizationId + providerRunId).Canonical provider contract
id(no compatibility fallback path in Comp forrunId).providerRunIdmapped from providerid.id.What changed
Frontend (
apps/app)/:orgId/security/:orgId/security/penetration-tests/:orgId/security/penetration-tests/:reportId/:orgId/security/penetration-tests/checkoutusePenetrationTestsusePenetrationTestusePenetrationTestProgressuseCreatePenetrationTestis-security-enabled.Backend (
apps/api)SecurityPenetrationTestsModuleGET /v1/security-penetration-testsPOST /v1/security-penetration-testsGET /v1/security-penetration-tests/:idGET /v1/security-penetration-tests/:id/progressGET /v1/security-penetration-tests/:id/reportGET /v1/security-penetration-tests/:id/pdfPOST /v1/security-penetration-tests/webhookDatabase (
packages/db)SecurityPenetrationTestRunsecurity_penetration_test_runsorganizationId + providerRunId(unique)Docs (
packages/docs)Environment variables
Required
MACED_API_KEYapps/apiOptional
MACED_API_BASE_URLapps/apihttps://api.maced.aiSECURITY_PENETRATION_TESTS_WEBHOOK_URLapps/apiNotes:
is-security-enabledis a PostHog feature flag (not an env var).Rollout
is-security-enabledOut of scope (intentional)
Risk/cost note